[Feat] Add Ray Cron Job #4159
[Feat] Add Ray Cron Job #4159
Conversation
machichima
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
| type RayCronJobSpec struct { | ||
| // JobTemplate defines the job spec that will be created by cron scheduling | ||
| JobTemplate *RayJobSpec `json:"jobTemplate"` | ||
| // Schedule is the cron schedule string | ||
| Schedule string `json:"schedule"` | ||
| } |
There was a problem hiding this comment.
Not sure if this is alright, but I think we should introduce a separate struct (e.g. RayJobTemplateSpec) to hold both the metadata and the spec for the generated RayJob, similar to how Kubernetes models JobTemplateSpec in CronJob.
This would allow users to specify metadata inside jobTemplate, which we can then propagate to the created RayJob. It also keeps the API aligned with common Kubernetes patterns.
WDYT?
There was a problem hiding this comment.
Not sure if we want this. In RayJobSpec when we specify the RayClusterSpec, we only set RayClusterSpec itself rather than also letting user set the ObjectMeta.
cc @rueian for confirmation.
There was a problem hiding this comment.
No need for it at the moment, this can be a future work.
There was a problem hiding this comment.
The current structure looks good to me already.
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
| rayVersion: '2.46.0' # should match the Ray version in the image of the containers | ||
| # Ray head pod template |
There was a problem hiding this comment.
can we use 2.52.0 version? thank you!
4 participants
Why are these changes needed?
Support cron job scheduling. Following this design docs and implement milestone 1 in this PR
Main changes:
RayCronJobCRD and controllerRayCronJobTest
Apply the sample YAML
ray-operator/config/samples/ray-cronjob.sample.yaml. RayJobs are being scheduled every minute:Trigger validation error
Related issue number
Following comment: #2426 (comment)
Closes #2426
Checks